Review follow-ups: PR #666 — feat(import): Add as custom card + imported dates keep their calendar day #900

New Issue

2026-09-30T07:17:41Z

gambit-admin commented

2026-09-30 07:17:41 +00:00

Non-blocking findings from the auto code review of PR #666 (feat(import): Add as custom card + imported dates keep their calendar day) — captured for batch cleanup rather than blocking the PR.
Commit 60d1dfa · https://github.com/Gambit-Inc/gambit/pull/666

SHOULD-FIX:

frontend/app/hq/imports/page.js:2036-2038 (TriageGrid) — the "grid" view's Accept button always calls onDecide(row, ...pickArgs(pick)) (→ choose) regardless of importable(cands[pick]), with no AddCustomCard/SearchForCard fallback rendered anywhere in this view (unlike the "cards" view, ParkedPanel, AutoReview, and DecidedRows, all of which got the new custom-card affordance in this diff). A seller who switches to the grid view (page.js:1679, user-toggleable) for a row whose only candidates lack a tcgplayer_id hits the same 409 dead end this PR was meant to fix, with no visible way to add the card as custom.

NITS:

none

Filed from a Claude Code session

Non-blocking findings from the auto code review of **PR #666** (feat(import): Add as custom card + imported dates keep their calendar day) — captured for batch cleanup rather than blocking the PR. Commit `60d1dfa` · https://github.com/Gambit-Inc/gambit/pull/666 SHOULD-FIX: 1. `frontend/app/hq/imports/page.js:2036-2038` (`TriageGrid`) — the "grid" view's Accept button always calls `onDecide(row, ...pickArgs(pick))` (→ `choose`) regardless of `importable(cands[pick])`, with no `AddCustomCard`/`SearchForCard` fallback rendered anywhere in this view (unlike the "cards" view, `ParkedPanel`, `AutoReview`, and `DecidedRows`, all of which got the new custom-card affordance in this diff). A seller who switches to the grid view (`page.js:1679`, user-toggleable) for a row whose only candidates lack a `tcgplayer_id` hits the same 409 dead end this PR was meant to fix, with no visible way to add the card as custom. NITS: none --- Filed from a Claude Code session

gambit-admin added the enhancement label 2026-09-30 07:17:41 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gambit/gambit#900