Review follow-ups: PR #700 — fix(scan): "Open on TCGplayer" follows the picked printing, not the scanned one #928

New Issue

2026-10-02T22:12:24Z

gambit-admin commented

2026-10-02 22:12:24 +00:00

Non-blocking findings from the auto code review of PR #700 (fix(scan): "Open on TCGplayer" follows the picked printing, not the scanned one) — captured for batch cleanup rather than blocking the PR.
Commit 5bbc2ca · https://github.com/Gambit-Inc/gambit/pull/700

SHOULD-FIX:

mobile/rork-recon-card-scanner/expo/components/CardDetailSheet.tsx:470-487 — tcgSalesQ (the "TCGPlayer" sold-listings tab) still builds its queryKey/URL from tcgProductId = Number(item?.match.tcgplayer_product_id ?? 0), the headline product id. This PR adds printingTcgProductId() and uses it to fix gambitSalesQ (line 491) and tcgUrl (line 607), but leaves this adjacent query on the old headline id. Pick a non-headline printing (e.g. the Altart in this PR's own Luffy OP16-015 test fixture), switch the sold tab to "TCGPlayer", and the sales shown are for the base/headline product, not the picked printing — the exact bug class the PR title claims to fix, half-done in the same component.

NITS:

backend/app/services/card_cache_projection.py:408-409 — the continuation-line indent for the new tcg_pid_by_variant parameter doesn't align with the opening paren of _build_price_variants(, inconsistent with the rest of the file's style (cosmetic only).

Filed from a Claude Code session

Non-blocking findings from the auto code review of **PR #700** (fix(scan): "Open on TCGplayer" follows the picked printing, not the scanned one) — captured for batch cleanup rather than blocking the PR. Commit `5bbc2ca` · https://github.com/Gambit-Inc/gambit/pull/700 SHOULD-FIX: - `mobile/rork-recon-card-scanner/expo/components/CardDetailSheet.tsx:470-487` — `tcgSalesQ` (the "TCGPlayer" sold-listings tab) still builds its queryKey/URL from `tcgProductId = Number(item?.match.tcgplayer_product_id ?? 0)`, the headline product id. This PR adds `printingTcgProductId()` and uses it to fix `gambitSalesQ` (line 491) and `tcgUrl` (line 607), but leaves this adjacent query on the old headline id. Pick a non-headline printing (e.g. the Altart in this PR's own Luffy OP16-015 test fixture), switch the sold tab to "TCGPlayer", and the sales shown are for the base/headline product, not the picked printing — the exact bug class the PR title claims to fix, half-done in the same component. NITS: - `backend/app/services/card_cache_projection.py:408-409` — the continuation-line indent for the new `tcg_pid_by_variant` parameter doesn't align with the opening paren of `_build_price_variants(`, inconsistent with the rest of the file's style (cosmetic only). --- Filed from a Claude Code session

gambit-admin added the enhancement label 2026-10-02 22:12:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gambit/gambit#928